<html>
<head><meta charset="utf-8"><title>Automatic pings for PRs touching argument handling · t-compiler/wg-incr-comp · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/index.html">t-compiler/wg-incr-comp</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Automatic.20pings.20for.20PRs.20touching.20argument.20handling.html">Automatic pings for PRs touching argument handling</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="241721733"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Automatic%20pings%20for%20PRs%20touching%20argument%20handling/near/241721733" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Automatic.20pings.20for.20PRs.20touching.20argument.20handling.html#241721733">(Jun 07 2021 at 02:12)</a>:</h4>
<p>I happened to take a look at PR <a href="https://github.com/rust-lang/rust/pull/86045">https://github.com/rust-lang/rust/pull/86045</a>, and realized that it would cause us to stop hashing certain command-line arguments as part of the incremental hash. While this wouldn't necessarily lead to an ICE, it was not intended by the author, and someone unfamiliar with the incremental compilation infrastructure would not have noticed.</p>
<p>I'm going to add myself to <a href="https://github.com/rust-lang/highfive/blob/d56ba3783390296da83a1d4c6201171568271c75/highfive/configs/rust-lang/rust.json">https://github.com/rust-lang/highfive/blob/d56ba3783390296da83a1d4c6201171568271c75/highfive/configs/rust-lang/rust.json</a> to get pinged for <code>rustc_session/src/{options.rs, config.rs}</code>, since they don't obviously deal with incremental compilation. Does anyone else want to get added (or should we potentially ping the wg Github team)?</p>



<a name="241778668"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Automatic%20pings%20for%20PRs%20touching%20argument%20handling/near/241778668" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Automatic.20pings.20for.20PRs.20touching.20argument.20handling.html#241778668">(Jun 07 2021 at 13:48)</a>:</h4>
<p>I thinking pinging the GH team makes sense.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>